[SOLVED] proposed fix for mylivecd

[AS]

Hi All,

looking at this thread: http://www.pclinuxos.com/forum/index.php/topic,89932
it appears that some filenames, containing some special characters, i.e. "(" and "&" , is actually affecting the behavior of mylivecd.

I do believe that mylivecd, as a backup tool, should be unaffected by any filenames a user may create, and that the script must be fixed, it look like the problems is that the filename is actually used inside a perl expression, and that in the end the expression is affected from the special characters that may be used in the filenames. The solution is to "escaping" "quote" the filename strings, so that when evaluated inside the expression, it's threated as a strings unit and not as a subexpression.

Problem look like to be in line 301 of mylivecd script:

Code: [Select]

               if (!defined($progress_text) || !($text =~ m/^$progress_text$/)) {
my proposasl is about to change this line as follow:

Code: [Select]

               if (!defined($progress_text) || !($text =~ m/^(\Q$progress_text\E)$/)) {

reference:
http://perldoc.perl.org/functions/quotemeta.html

I'm absolutely not a perl programmer, therefore I ask that my guess could be verified by someone more expert.

AS

[kjpetrie]

Why not just:

Code: [Select]


 if (!defined($progress_text) || ($text ne $progress_text)) {

The context doesn't appear to need a regular expression match - just an equality check - and REs are resource-expensive.

[AS]

Why not just:

Code: [Select]


 if (!defined($progress_text) || ($text ne $progress_text)) {

The context doesn't appear to need a regular expression match - just an equality check - and REs are resource-expensive.

Thank you kjpetrie,

just seen the fix you proposed found it's way in the latest mylivecd update! 

Thank you Texstar!

AS