Zenity Script Help for getvirtualbox.

[travisN000]

At any place in the script where zenity is called, this script should be added. That would be in about 6 or 7 places, I think.

# download VirtualBox
#=================================================
# maybe here?
if [ $? = 1 ];
then exit 0
fi
MSG=$"Downloading VirtualBox (53mb). Please be patient..."
( wget $source ) 2>&1 | $ZEN2 --width 500 --title="$TITLE" --progress --text "$MSG" --pulsate --auto-close

# maybe here?
if [ $? = 1 ];
then exit 0
fi

nope neither works... I dunno...  

...has anyone tried adding the --auto-kill option on that progress dialog?  It is suppose to kill the parent process.

I've got a few other ideas, but I think it will be a few days until I can spend any real time on it.

[pinoc]

just to avoid duplicated efforts, looking into it right now and added/changed things as needed. So far works well and should be ready soon after some more refinements.
-p.

[Neal ManBear]

I awaken from sleep, and what do I find? Tex thinks I'm blind. Galen thinks I left out the closing empty line. Travis suggests --auto-kill. And Pinoc has the script working.

So what's the moral of the story? -->
Amazing things happen around here. Don't fall asleep, or you'll miss 'em.

 

[menotu]

Thats Zen for you

[Village Idiot]

I awaken from sleep, and what do I find? Tex thinks I'm blind. Galen thinks I left out the closing empty line. Travis suggests --auto-kill. And Pinoc has the script working.

So what's the moral of the story? -->
Amazing things happen around here. Don't fall asleep, or you'll miss 'em.

 

You snooze, you lose!   

[travisN000]

just to avoid duplicated efforts, looking into it right now and added/changed things as needed. So far works well and should be ready soon after some more refinements.
-p.

..maybe when this is done we can also put together a VMware version; IIRC it uses a similar .run install script.  


With all of these GetXXX scripts, would it be a good idea to put together some sort of dummy metapackage for the main repo that could auto-launch the script (or notify the user) when its version/release is updated in the repo's; it could possibly be used be used to force a re-install / rebuild of kernel modules when kernels change, etc.  

I played with this sort of idea for another package awhile ago..  putting a zenity dialog / bash script in the spec file %pre or %post sections does work, and can be used to create an interactive install or update experience.

..a short script in the %pre section might check if VBox is already installed; in which case it could be assumed that the updated metapackage signals a new version avialable and prompt the user; dealing with kernel changes is more tricky.. perhaps the getVBox script could log kernel at VBox install and the %pre scripts could also check this.  This might be better handled by an kernel checking script integrated into the .desktop launcher.

[Texstar]

just to avoid duplicated efforts, looking into it right now and added/changed things as needed. So far works well and should be ready soon after some more refinements.
-p.

Yes but I wanted to avoid xterm because it is butt ugly. Here is my updated code that shows a progress bar while downloading the file. Still need to fix the cancel buttons.
 
changelog
- show progress bar with download speed and time left when downloading package
- add usb group in case it doesn't exist
- add user to usb group as well so they get usb support

Code: [Select]

#!/bin/bash -l

# getvirtualbox
#
# Copyright (C) 2010 Bill Reynolds <texstar@gmail.com>
#
#    This program is free software; you can redistribute it and/or modify
#    it under the terms of the GNU General Public License as published by
#    the Free Software Foundation; either version 2 of the License, or
#    (at your option) any later version.
#
#    This program is distributed in the hope that it will be useful,
#    but WITHOUT ANY WARRANTY; without even the implied warranty of
#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
#    GNU General Public License for more details.
#
#    You should have received a copy of the GNU General Public License
#    along with this program; if not, write to the Free Software
#    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
#

# define some variables
#=================================================
TITLE="GetVirtualBox 3.2.2"
package="VirtualBox-3.2.2-62298-Linux_x86.run"
source="http://download.virtualbox.org/virtualbox/3.2.2/"$package
ZEN2="zenity"


# check for working internet connection
#=================================================
cd /tmp
/bin/rm -f index.html inet.log
MSG=$"Testing your Internet connection..."
( wget --timeout=15 http://www.google.com/index.html -o inet.log ) 2>&1 | $ZEN2 --title="$TITLE" --progress --text "$MSG" --pulsate --auto-close


if [ ! -f /tmp/index.html ]; then
MSG=$"No Internet connection found.\n\nExiting..."
$ZEN2 --title="$TITLE" --error --text "$MSG"
exit 0
fi

# clean up and make sure no partial downloads exist in /tmp
/bin/rm -f index.html inet.log VirtualBox*


# download VirtualBox
#=================================================
#MSG=$"Downloading VirtualBox (53mb). Please be patient..."
wget $source 2>&1 | sed -u 's/.* \([0-9]\+%\)\ \+\([0-9.]\+.\) \(.*\)/\1\n# Downloading at \2\/s, ETA \3/' | $ZEN2 --width 500 --progress --title="$TITLE" --auto-close


#make file executable
#=================================================
chmod a+x $package

# run the installer
#=================================================
MSG=$"Installing VirtualBox. Please be patient..."
( sh $package ) 2>&1 | $ZEN2 --width 500 --title="$TITLE" --progress --text "$MSG" --pulsate --auto-close


# Create usb group if it doesn't exist, won't hurt if usb group already exists
#=================================================
groupadd usb


# Virtualbox installer automatically adds vboxusers group, yaa
#=================================================


# add users to group vboxusers and usb
#=================================================
SYSUSERS=`cat /etc/passwd | grep "/home/.*/bash" |grep "[0-9][0-9][0-9]" |cut -d: -f1`
for idx in $SYSUSERS; do usermod -G vboxusers,usb $idx; done


# Remove created symlink and make actual desktop file
#=================================================
if [ -f /usr/share/applications/virtualbox.desktop ]; then
/bin/rm -rf /usr/share/applications/virtualbox.desktop
fi

# create menu entry for PCLinuxOS
#=================================================
cat >/usr/share/applications/virtualbox.desktop << EOF
[Desktop Entry]
Encoding=UTF-8
Version=1.0
Name=Oracle VM VirtualBox
GenericName=Virtual Machine
Type=Application
Exec=VirtualBox
TryExec=VirtualBox
DocPath=file:///opt/VirtualBox/UserManual.pdf
Icon=VBox
Categories=Emulator;System;X-MandrivaLinux-MoreApplications-Emulators;
Comment=Run several virtual systems on a single host computer
EOF


# clean up
#=================================================
/bin/rm -f $package

# the end
#=================================================
MSG=$"VirtualBox is now available from the menu under\nPCmenu -> More Applications -> Emulators.\n\nHave fun\!"
$ZEN2 --width 500 --title="$TITLE" --info --text="$MSG"
exit 0



[Neal ManBear]

Added a couple of things to your script. Cancel now works.

Code: [Select]

#!/bin/bash -l

# getvirtualbox
#
# Copyright (C) 2010 Bill Reynolds <texstar@gmail.com>
#
#    This program is free software; you can redistribute it and/or modify
#    it under the terms of the GNU General Public License as published by
#    the Free Software Foundation; either version 2 of the License, or
#    (at your option) any later version.
#
#    This program is distributed in the hope that it will be useful,
#    but WITHOUT ANY WARRANTY; without even the implied warranty of
#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
#    GNU General Public License for more details.
#
#    You should have received a copy of the GNU General Public License
#    along with this program; if not, write to the Free Software
#    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
#

# define some variables
#=================================================
TITLE="GetVirtualBox 3.2.2"
package="VirtualBox-3.2.2-62298-Linux_x86.run"
source="http://download.virtualbox.org/virtualbox/3.2.2/"$package
ZEN2="zenity"
exit1=--kill-all

# check for working internet connection
#=================================================
cd /tmp
/bin/rm -f index.html inet.log
MSG=$"Testing your Internet connection..."
( wget --timeout=15 http://www.google.com/index.html -o inet.log ) 2>&1 | $ZEN2 --title="$TITLE" --progress --text "$MSG" --pulsate --auto-close


if [ ! -f /tmp/index.html ]; then
MSG=$"No Internet connection found.\n\nExiting..."
$ZEN2 --title="$TITLE" --error --text "$MSG"
exit 0
fi

# clean up and make sure no partial downloads exist in /tmp
/bin/rm -f index.html inet.log VirtualBox*

if [ $? = 1 ];
then $exit1
fi

# download VirtualBox
#=================================================
#MSG=$"Downloading VirtualBox (53mb). Please be patient..."
wget $source 2>&1 | sed -u 's/.* \([0-9]\+%\)\ \+\([0-9.]\+.\) \(.*\)/\1\n# Downloading at \2\/s, ETA \3/' | $ZEN2 --width 500 --progress --title="$TITLE" --auto-close


#make file executable
#=================================================
chmod a+x $package

# run the installer
#=================================================
MSG=$"Installing VirtualBox. Please be patient..."
( sh $package ) 2>&1 | $ZEN2 --width 500 --title="$TITLE" --progress --text "$MSG" --pulsate --auto-close


# Create usb group if it doesn't exist, won't hurt if usb group already exists
#=================================================
groupadd usb


# Virtualbox installer automatically adds vboxusers group, yaa
#=================================================


# add users to group vboxusers and usb
#=================================================
SYSUSERS=`cat /etc/passwd | grep "/home/.*/bash" |grep "[0-9][0-9][0-9]" |cut -d: -f1`
for idx in $SYSUSERS; do usermod -G vboxusers,usb $idx; done


# Remove created symlink and make actual desktop file
#=================================================
if [ -f /usr/share/applications/virtualbox.desktop ]; then
/bin/rm -rf /usr/share/applications/virtualbox.desktop
fi

# create menu entry for PCLinuxOS
#=================================================
cat >/usr/share/applications/virtualbox.desktop << EOF
[Desktop Entry]
Encoding=UTF-8
Version=1.0
Name=Oracle VM VirtualBox
GenericName=Virtual Machine
Type=Application
Exec=VirtualBox
TryExec=VirtualBox
DocPath=file:///opt/VirtualBox/UserManual.pdf
Icon=VBox
Categories=Emulator;System;X-MandrivaLinux-MoreApplications-Emulators;
Comment=Run several virtual systems on a single host computer
EOF


# clean up
#=================================================
/bin/rm -f $package

# the end
#=================================================
MSG=$"VirtualBox is now available from the menu under\nPCmenu -> More Applications -> Emulators.\n\nHave fun\!"
$ZEN2 --width 500 --title="$TITLE" --info --text="$MSG"
exit 0


[Neal ManBear]

After multiple attempts to get the script

Code: [Select]

if [ $? = 1 ];
then exit
fi
to work -- various places, etc -- the idea occurred to me: If the script isn't working, rewrite it. So I did.

Sad, isn't it, that it took two days to think of that?

[Texstar]

After multiple attempts to get the script

Code: [Select]

if [ $? = 1 ];
then exit
fi
to work -- various places, etc -- the idea occurred to me: If the script isn't working, rewrite it. So I did.

Sad, isn't it, that it took two days to think of that?

I'm sorry but that doesn't do anything other than close the zenity box. wget is still running, downloading the package unless I Control-C it in the konsole.

[Neal ManBear]

  It stopped here. Sheep-dip!
Sorry, Tex, I thought I had it.

[Texstar]

It stopped here. Sheep-dip!
Sorry, Tex, I thought I had it.

I almost got it now.. Except the script stops after downloading. The cancel works though! LOL

Edit: removed the exit 0 in the loopscript.

 

Code: [Select]

#!/bin/bash -l

# getvirtualbox
#
# Copyright (C) 2010 Bill Reynolds <texstar@gmail.com>
#
#    This program is free software; you can redistribute it and/or modify
#    it under the terms of the GNU General Public License as published by
#    the Free Software Foundation; either version 2 of the License, or
#    (at your option) any later version.
#
#    This program is distributed in the hope that it will be useful,
#    but WITHOUT ANY WARRANTY; without even the implied warranty of
#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
#    GNU General Public License for more details.
#
#    You should have received a copy of the GNU General Public License
#    along with this program; if not, write to the Free Software
#    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
#

# define some variables
#=================================================
TITLE="GetVirtualBox 3.2.2"
package="VirtualBox-3.2.2-62298-Linux_x86.run"
source="http://download.virtualbox.org/virtualbox/3.2.2/"$package
ZEN2="zenity"


# check for working internet connection
#=================================================
cd /tmp
/bin/rm -f index.html inet.log
MSG=$"Testing your Internet connection..."
( wget --timeout=15 http://www.google.com/index.html -o inet.log ) 2>&1 | $ZEN2 --title="$TITLE" --progress --text "$MSG" --pulsate --auto-close


if [ ! -f /tmp/index.html ]; then
MSG=$"No Internet connection found.\n\nExiting..."
$ZEN2 --title="$TITLE" --error --text "$MSG"
exit 0
fi

# clean up and make sure no partial downloads exist in /tmp
/bin/rm -f index.html inet.log VirtualBox*


# download VirtualBox
#=================================================
#MSG=$"Downloading VirtualBox (53mb). Please be patient..."
wget $source 2>&1 | sed -u 's/.* \([0-9]\+%\)\ \+\([0-9.]\+.\) \(.*\)/\1\n# Downloading at \2\/s, ETA \3/' | $ZEN2 --width 500 --progress --title="$TITLE" --auto-close &

#Start a loop testing if zenity is running, and if not kill wget
RUNNING=0
while [ $RUNNING -eq 0 ]
do
if [ -z "$(pidof zenity)" ]
then
 pkill wget
 RUNNING=1
fi
done


#make file executable
#=================================================
chmod a+x $package

# run the installer
#=================================================
MSG=$"Installing VirtualBox. Please be patient..."
( sh $package ) 2>&1 | $ZEN2 --width 500 --title="$TITLE" --progress --text "$MSG" --pulsate --auto-close


# Create usb group if it doesn't exist
#=================================================
groupadd usb


# Virtualbox installer automatically adds vboxusers group
#=================================================


# add users to group vboxusers and usb
#=================================================
SYSUSERS=`cat /etc/passwd | grep "/home/.*/bash" |grep "[0-9][0-9][0-9]" |cut -d: -f1`
for idx in $SYSUSERS; do usermod -a -G vboxusers,usb $idx; done


# Remove created symlink and make actual desktop file
#=================================================
if [ -f /usr/share/applications/virtualbox.desktop ]; then
/bin/rm -rf /usr/share/applications/virtualbox.desktop
fi

# create menu entry for PCLinuxOS
#=================================================
cat >/usr/share/applications/virtualbox.desktop << EOF
[Desktop Entry]
Encoding=UTF-8
Version=1.0
Name=Oracle VM VirtualBox
GenericName=Virtual Machine
Type=Application
Exec=VirtualBox
TryExec=VirtualBox
DocPath=file:///opt/VirtualBox/UserManual.pdf
Icon=VBox
Categories=Emulator;System;X-MandrivaLinux-MoreApplications-Emulators;
Comment=Run several virtual systems on a single host computer
EOF


# clean up
#=================================================
/bin/rm -f $package

# the end
#=================================================
MSG=$"VirtualBox is now available from the menu under\nPCmenu -> More Applications -> Emulators.\n\nHave fun\!"
$ZEN2 --width 500 --title="$TITLE" --info --text="$MSG"
exit 0

[parnote]

I'm watching this ... I was having the same problem with gtkdialog this past week/weekend.

parnote

[Neal ManBear]

gtkdialog has given me difficulties recently. That's why I started learning (correction: trying to learn) zenity.

[travisN000]

I think I found a solution to killing wget (and other child processes) with the wget>sed>zenity pipe...  the nice thing about this solution is that it will not kill external wget processes (..from download managers, etc), it only kills processes that are started by the script.  This method should also be a little less resource intensive than the previous fix, as it does not create a continuously running loop.

I also modified the progress box slightly so that ETA is on a new line (..watching it bounce around in test after test was making me feel ill!   )


(this is not the entire script..  just up through the pipe problem  )


EDIT: ..removed, will post full script momentarily.