Looking for Perl Master to fix AcidRip's progress output

[travisN000]

      if (/^Pos:\s*(\d+)\.\ds\s+(\d+)f\s+\(\s*(\d+)%\)\s+([\d.]+fps)\sTrem:\s+(\d+min)\s+(\d+mb).+\[([\d:]+)\]/) {[/color][/b]
          if ( $0 ne $sec )  { $sec  = $1; $::widgets->{'menc_seconds'}->set_text( hhmmss($1) ) }
          if ( $0 ne $fps )  { $fps  = $4; $::widgets->{'menc_fps'}->set_text($4) }
          if ( $0 ne $size ) { $size = $6; $::widgets->{'menc_filesize'}->set_text($6) }
          if ( $0 ne $time ) { $time = $5; $::widgets->{'menc_time'}->set_text($5) }
          if ( $0 ne $rate ) { $rate = $7; $::widgets->{'menc_bitrate'}->set_text($7) }

...Since the data gets updated properly if you make the IF FALSE, I'm at a bit of a loss.

Changing them to $0 makes the IF statements you highlighted (in red) evaluate to TRUE... that is why it works.  If they evaluated to FALSE the data in the progress dialog would not get updated.  I'm pretty sure this is what you meant, but thought I would point it out just in case anyone else is following along.  



..looking at it again, I found another (better) fix ..note the quotes in red; no $0 needed (still using updated regex):

       if (/^Pos:\s*(\d+)\.\ds\s+(\d+)f\s+\(\s*(\d+)%\)\s+([\d.]+fps)\sTrem:\s+(\d+min)\s+(\d+mb).+\[([\d:]+)\]/) {
          if ( $1 ne $sec )  { $sec  = $1; $::widgets->{'menc_seconds'}->set_text( hhmmss($1) ) }
          if ( $4 ne $fps )  { $fps  = $4; $::widgets->{'menc_fps'}->set_text("$4") }
          if ( $6 ne $size ) { $size = $6; $::widgets->{'menc_filesize'}->set_text("$6") }
          if ( $5 ne $time ) { $time = $5; $::widgets->{'menc_time'}->set_text("$5") }
          if ( $7 ne $rate ) { $rate = $7; $::widgets->{'menc_bitrate'}->set_text("$7") }

[travisN000]

another fix that might be worth testing...  AcidRip / Gtk was generating errors in console: "GtkSpinButton: setting an adjustment with non-zero page size is deprecated" at various lines in AcidRip's interface.pm...  

I changed them all to zero values (file attached) and the errors are now gone; I haven't tested extensively to see if any new issues pop up as a result, but it seems to work as expected.  If there are any related problems they would show up in the GUI's input boxes that have the up and down arrows for changing number values (ie. file size, video crop size settings, etc).

[daniel]

Summary, that's also the patch file?
progress output, and interface added as one patch file....

[travisN000]

..looks good;  has anyone other than me tested it?

[daniel]

have the package generated and works fine, without any errors

[daniel]

send or not send, that's the question 

[travisN000]

It works for me, and it works for you...   nobody else has voiced otherwise, so I say send it up! 

[daniel]

ok, i do that...

[wyohman]

I haven't tried it but all of the changes are relatively minor and it's not being worked upstream at all. Send it!

Cheers.