webmin1.470

[Joble]

hehe, that and I still gotta add the service webmin restart line to the spec file, but I think I can get this built over my lunch break and get another one up to test.      I hope.

[travisN000]

..it's my Friday, so I can test later this evening if needed!

How is it going getting the paths correct?  I would think the easiest solution would be to pull the conf files from a BEL liveCD and then add them as source1, source2, etc to the spec; they can then be used to overwrite webmin defaults.

[Joble]

The .conf files are correct in the source, as long as the distro is correctly identified.   

He's done a good job on this one. 

[Was_Just19]

I realise this is a little OT, but have often wondered if such RPMs/SRPMS are sent back to the developer after completion?

It struck me as a very useful exercise where PCLOS gains from the extra notice it gets and the developer is saved the time needed to make whatever changes are incorporated.

[Joble]

Well, once I figure out what's going on I might just do that, if I get it working right.

It's still showing up as generic, and my tmp folder continues to change permissions to root every time I build it, so there's more issues I gotta figure out.

[YouCanToo]

I realise this is a little OT, but have often wondered if such RPMs/SRPMS are sent back to the developer after completion?

It struck me as a very useful exercise where PCLOS gains from the extra notice it gets and the developer is saved the time needed to make whatever changes are incorporated.

I spoke with Jamie the other day about the issue of Webmin not seeing PCLinuxOS and he assured me that he would have it corrected in the next release of Webmin.

[Joble]

OK, I'm gettin mad! 

When I install the rpm right now it says:

Preparing                                ############################## [100%]
Operating system is Mandrake-Linux
Updating / installing
  webmin-1.470-1pclos2009.noarch         ############################## [100%]
Webmin install complete. You can now login to http://localhost:10000/
as root with your root password.

But, when I run it, it still says generic and all the paths are wrong!  AAAAArrrgg!

BTW:  I'm getting now why the texstar does things the PCLOS way!  Solved the tmp folder permissions issue with %{_tmppath}   

-----------------------------------
Update: 
1. Now the temp files in src/tmp are owned by root so I still have to go in and delete them as root after every build.
2. The oscheck in the spec file only announces the OS during install, it has nothing to do with how the build detects it.
3. I suspect the oscheck needs root access, though I don't know why it should, I will try building this as root on my testbox and see if it makes a difference.

[Joble]

SUCCESS!  Got a couple things to tweak and I will send up another test version!

YouCanToo:  In os_list.txt
added:
PCLinuxOS         2007   mandrake-linux   10.3   `cat /etc/mandrake-release 2>/dev/null` =~ /PCLinuxOS\s+release\s+2007/i
PCLinuxOS         2009   mandrake-linux   10.3   `cat /etc/mandrake-release 2>/dev/null` =~ /PCLinuxOS\s+release\s+2009/i

Turned out to be a simple fix, editing the spec file to match, which I did earlier.  Still got a couple things to tweak in the spec file before I turn it in for a grade.   

[Joble]

Well, I solved the tmp permissions problem during the build, but it is still changing the permissions on my home tmp during install and uninstall.  I think this is the culprit, but I'm not positive:

Code: [Select]

perl <<EOD;
# maketemp.pl
# Create the /tmp/.webmin directory if needed

\$tmp_dir = \$ENV{'tempdir'} || "/tmp/.webmin";
while(\$tries++ < 10) {
local @st = lstat(\$tmp_dir);
exit(0) if (\$st[4] == \$< && (-d _) && (\$st[2] & 0777) == 0755);
if (@st) {
unlink(\$tmp_dir) || rmdir(\$tmp_dir) ||
system("/bin/rm -rf ".quotemeta(\$tmp_dir));
}
mkdir(\$tmp_dir, 0755) || next;
chown(\$<, \$(, \$tmp_dir);
chmod(0755, \$tmp_dir);
}
exit(1);

EOD

[Neal ManBear]

I may be wrong, but it looks like webmin should be creating a .webmin hidden file in root's tmp but is commandeering /home/tmp for the purpose.

# Create the /tmp/.webmin directory if needed

It changes the ownership of /home/tmp to do this because it has been told to:

mkdir(\$tmp_dir, 0755) || next;
   chown(\$<, \$(, \$tmp_dir);
   chmod(0755, \$tmp_dir);

I could be misreading this, but if I'm not, you'll need to tell it specifically to use /root/tmp. Change:

Code: [Select]

  $  to

Code: [Select]

  #

[Was_Just19]

Hope you don't mind the butting in ......

Webmin not installed ......
I have no  /home/tmp
I have a /home/<user>/tmp which has no permissions because it is just a link to /tmp and is owned by root.

Butt out again .... 

[Joble]

New source uploaded, but I don't encourage anyone to play with it yet, unless your helping build it.

Before install:
lrwxrwxrwx 1 joe  joe          4 May  9 14:19 tmp -> /tmp/
After install (and also after uninstall):
drwxr-xr-x 2 root root      4096 May  9 16:32 tmp/

Far as I know, that's the only thing left to fix.

new .rpm and src.rpm uploaded.  Any help appreciated.

BTW:  This will be awesome, once we get the install working.

JohnBoy: hehe, Good point.  I tend to assume people know what I mean, sometimes. 

If anyone wants to try this, to test out the paths and stuff, that's great, just be aware of the issues with tmp.

[ElCuervo]

Yes, I can hardly wait!

[travisN000]

New source uploaded, but I don't encourage anyone to play with it yet, unless your helping build it.

..uploaded where??

[Joble]

http://nbrks.com/rpm/webmin/