i read a bit in the script and it needs root rights so it should be installed to /usr/sbin not /usr/bin
it uses wget or curl so you should add wget or curl as Requires
the rest of required things seems to be core stuff which should be installed everywhere
ah and your defined version seems to miss a dot
except of this three little things it looks very ok for me
That was new to me. Can I take it in general that anything that needs to run as root should go into /usr/sbin?
Regarding wget/curl - are they not for updating the application itself? It says updating the application does not require root. Anyway as we do not prefer applications that auto-update, it may not be important I guess. Unless I am missing something else here.
The version dot. It confused the hell out of me. It looks like the actual directory inside the source tarball does not have the dot in its name. Although the version is properly named the directory is not. Either I had to open the tarball, rename directory and then recompress or I could adjust the .spec. I went for the latter. Is it wrong to do that?