[PACKAGED] KOceanSaver - Not working as expected

[sling-shot]

http://sourceforge.net/projects/koceansaver/

KOceanSaver
-----------------
A KDE 4 screensaver that shows an underwater ocean seen with sea creatures. In particular, swimming Baracudas and sharks. A treasure chest lies on the sea floor with a ship wrecked in the background.

The build fails with the following error condition:

Code: [Select]

CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:97 (message):
  Could NOT find kscreensaver (missing: KSCREENSAVER_LIBRARY
  KSCREENSAVER_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:291 (_FPHSA_FAILURE_MESSAGE)
  CMakeLists.txt:21 (find_package_handle_standard_args)


-- Configuring incomplete, errors occurred!
error: Bad exit status from /home/testinstall/src/tmp/rpm-tmp.UZuhsk (%build)


RPM build errors:
    Bad exit status from /home/testinstall/src/tmp/rpm-tmp.UZuhsk (%build)

.spec used :

Code: [Select]

Name: KOceanSaver
Version: 0.71
Release: %mkrel 1
Summary: An ocean aquarium screensaver
# The Group may be redefined later to conform with PCLinuxOS convention
Group: System/Configuration/Screensavers
License: GPLv2
URL: http://www.kde-look.org
Source: KOceanSaver-%{version}.tar.gz
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot
BuildRequires: cmake
BuildRequires: kde-artwork-kscreensaver

%description
A KDE 4 screensaver that shows an underwater ocean seen with sea creatures.
In particular, swimming Baracudas and sharks.
A treasure chest lies on the sea floor with a ship wrecked in the background.

%prep
%setup -q -n %{name}

%build
#cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr CMakeLists.txt
%cmake

%make

%install
rm -rf $RPM_BUILD_ROOT
%makeinstall

%clean
rm -rf $RPM_BUILD_ROOT

#Please neglect this section at present. Will be updated once the build reaches this stage.
%files
%defattr(-,root,root,-)
#/usr/bin/lookat
#/usr/bin/bekijk
#doc /usr/share/doc/lookat/README
#doc /usr/share/doc/lookat/examples/blue_config.cfg
#doc /usr/share/man/man1/bekijk.1.bz2
#doc /usr/share/man/man1/lookat.1.bz2
#doc /usr/share/doc/lookat/LEESMIJ
#config /etc/lookat.conf
#config /etc/lookat.conf.default

%changelog
* Mon Mar 25 2013 Sling Shot <sling-shot at lycos.com>
- Initial build.

INSTALL file from the package:

Code: [Select]

To build KOceanSaver you will need a basic build system (g++, make, etc.)  You
will also need to install cmake and selected Qt4 and KDE4 development packages.
On Debian-based systems
    apt-get install build-essential kdebase-workspace-dev libqt4-opengl-dev
should be sufficient.

KOceanSaver also comes with a simple configure script that should work for a
generic local install.  If it doesn't suit your needs, you will need to edit the
cmake settings by hand.

Install:
  cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr CMakeLists.txt
  make
  sudo make install

Note: If you do a local installation, you might not see KOceanSaver in the Screen
Saver Settings module.  In that case, you will need to do one of two things.

After that, you may need to manually refresh the system configuration cache by
running 'kbuildsycoca4'.  KOceanSaver should now appear in Screen Saver Settings.


[sling-shot]

Our repository has only one package referencing kscreensaver and that is already installed. There is no devel package. Is it because I am missing some devel package?

[TerryN]

You need kde-workspace-devel (as it suggests in the docs)

Terry.
P.S. Please (re)compress the source with xz to save space on our Dropbox and servers  

[sling-shot]

Aha! It was right in front of my eyes and still I missed it. Same old same old. Thanks for putting up with me Terry.

-------------

This is probably the second package tar.gz archive that I have recompressed using RightClick menu into tar.xz and that ended up with the following result. I am not sure whether some parameter has changed in my install or if any update has resulted in this or is a faulty tar.gz the cause.

To avoid this I used tar.gz.

Code: [Select]

Executing(%prep): /bin/sh -e /home/testinstall/src/tmp/rpm-tmp.aPaWP9
+ umask 022
+ cd /home/testinstall/src/rpm/BUILD
+ '[' 1 -eq 1 ']'
+ '[' 1 -eq 1 ']'
+ '[' 1 -eq 1 ']'
+ cd /home/testinstall/src/rpm/BUILD
+ rm -rf KOceanSaver
+ /usr/bin/xz -dc /home/testinstall/src/rpm/SOURCES/KOceanSaver-0.71.tar.xz
+ /bin/tar -xf -
/bin/tar: Archive value -335541848032 is out of time_t range -2147483648..2147483647
/bin/tar: Ignoring unknown extended header keyword `SCHILY.devminor'
/bin/tar: Ignoring unknown extended header keyword `SCHILY.dev'
/bin/tar: Ignoring unknown extended header keyword `SCHILY.ino'
/bin/tar: Ignoring unknown extended header keyword `SCHILY.nlink'
/bin/tar: KOceanSaver-0.71: Cannot mknod: Operation not permitted
/bin/tar: Exiting with failure status due to previous errors
error: Bad exit status from /home/testinstall/src/tmp/rpm-tmp.aPaWP9 (%prep)


RPM build errors:
    Bad exit status from /home/testinstall/src/tmp/rpm-tmp.aPaWP9 (%prep)


[TerryN]

This is probably the second package tar.gz archive that I have recompressed using RightClick menu into tar.xz and that ended up with the following result. I am not sure whether some parameter has changed in my install or if any update has resulted in this or is a faulty tar.gz the cause.

I always do:

Code: [Select]

gunzip file.tar.gz
xz file.tar

Has never failed yet 

Terry.

[sling-shot]

You are right there. Although GUI method failed me, this worked. Hence I will keep this commandline method as a backup when the GUI fails.

-----
This package does not appear in my Synaptic search (32 bit)
libqt4-opengl-dev
-----

With the kde-workspace-devel the build progressed to stall at this point :

Code: [Select]

Executing(%prep): /bin/sh -e /home/testinstall/src/tmp/rpm-tmp.Zu8Q3i
+ umask 022
+ cd /home/testinstall/src/rpm/BUILD
+ '[' 1 -eq 1 ']'
+ '[' 1 -eq 1 ']'
+ '[' 1 -eq 1 ']'
+ cd /home/testinstall/src/rpm/BUILD
+ rm -rf KOceanSaver
+ /usr/bin/xz -dc /home/testinstall/src/rpm/SOURCES/KOceanSaver-0.71.tar.xz
+ /bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd KOceanSaver
+ exit 0
Executing(%build): /bin/sh -e /home/testinstall/src/tmp/rpm-tmp.QP1FSC
+ umask 022
+ cd /home/testinstall/src/rpm/BUILD
+ cd KOceanSaver
+ '[' 1 -eq 1 ']'
+ '[' 1 -eq 1 ']'
+ CFLAGS='-O2  -pipe -Wformat -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables'
+ export CFLAGS
+ CXXFLAGS='-O2  -pipe -Wformat -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables'
+ export CXXFLAGS
+ FFLAGS='-O2  -pipe -Wformat -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables'
+ export FFLAGS
+ mkdir -p build
+ cd build
+ /usr/bin/cmake .. -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_INSTALL_LIBDIR:PATH=/usr/lib -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DCMAKE_BUILD_TYPE=release -DCMAKE_SKIP_RPATH:BOOL=ON -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_STATIC_LIBS:BOOL=OFF '-DCMAKE_MODULE_LINKER_FLAGS=-Wl,--as-needed  -Wl,-z,relro'
-- The C compiler identification is GNU 4.5.2
-- The CXX compiler identification is GNU 4.5.2
-- Check for working C compiler: /usr/lib/ccache/bin/cc
-- Check for working C compiler: /usr/lib/ccache/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/lib/ccache/bin/c++
-- Check for working CXX compiler: /usr/lib/ccache/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Looking for Q_WS_X11
-- Looking for Q_WS_X11 - found
-- Looking for Q_WS_WIN
-- Looking for Q_WS_WIN - not found
-- Looking for Q_WS_QWS
-- Looking for Q_WS_QWS - not found
-- Looking for Q_WS_MAC
-- Looking for Q_WS_MAC - not found
-- Found Qt-Version 4.8.4 (using /usr/bin/qmake)
-- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so;/usr/lib/libXft.so;/usr/lib/libXau.so;/usr/lib/libXdmcp.so;/usr/lib/libXpm.so
-- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so;/usr/lib/libXft.so;/usr/lib/libXau.so;/usr/lib/libXdmcp.so;/usr/lib/libXpm.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found X11: /usr/lib/libX11.so
-- Looking for include file pthread.h
-- Looking for include file pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE 
-- Found OpenSSL: /usr/lib/libssl.so;/usr/lib/libcrypto.so (found version "1.0.0e")
-- Looking for _POSIX_TIMERS
-- Looking for _POSIX_TIMERS - found
-- Found Automoc4: /usr/bin/automoc4 
-- Found Perl: /usr/bin/perl (found version "5.10.1")
-- Found Phonon: /usr/include (Required is at least version "4.3.80")
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Failed
-- Performing Test HAVE_FPIE_SUPPORT
-- Performing Test HAVE_FPIE_SUPPORT - Success
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test __KDE_HAVE_GCC_VISIBILITY
-- Performing Test __KDE_HAVE_GCC_VISIBILITY - Success
-- Found KDE 4.10 include dir: /usr/include
-- Found KDE 4.10 library dir: /usr/lib
-- Found the KDE4 kconfig_compiler preprocessor: /usr/bin/kconfig_compiler
-- Found automoc4: /usr/bin/automoc4
-- Found OpenGL: /usr/lib/libGL.so 
-- Found kscreensaver: /usr/lib/libkscreensaver.so 
-- Found libGL: /usr/lib/libGL.so 
-- Found libGLU: /usr/lib/libGLU.so 
-- Found QtOpenGL: Qt4::QtOpenGL 
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_STATIC_LIBS
    CMAKE_INSTALL_LIBDIR


-- Build files have been written to: /home/testinstall/src/rpm/BUILD/KOceanSaver/build
+ make -j2
Scanning dependencies of target koceansaver.kss_automoc
Generating moc_kocean.cpp
Generating moc_koceansetup.cpp
[  0%] Built target koceansaver.kss_automoc
[ 11%] Generating ui_koceansetup.h
Scanning dependencies of target koceansaver.kss
[ 22%] [ 33%] Building CXX object src/CMakeFiles/koceansaver.kss.dir/koceansaver.kss_automoc.cpp.o
Building CXX object src/CMakeFiles/koceansaver.kss.dir/guidancesystem.cpp.o
[ 44%] Building CXX object src/CMakeFiles/koceansaver.kss.dir/koceansetting.cpp.o
[ 55%] Building CXX object src/CMakeFiles/koceansaver.kss.dir/ocean.cpp.o
[ 66%] Building CXX object src/CMakeFiles/koceansaver.kss.dir/wavemap.cpp.o
[ 77%] Building CXX object src/CMakeFiles/koceansaver.kss.dir/kocean.cpp.o
[ 88%] Building CXX object src/CMakeFiles/koceansaver.kss.dir/koceansetup.cpp.o
[100%] Building CXX object src/CMakeFiles/koceansaver.kss.dir/seacreature.cpp.o
Linking CXX executable koceansaver.kss
[100%] Built target koceansaver.kss
+ exit 0
Executing(%install): /bin/sh -e /home/testinstall/src/tmp/rpm-tmp.sKQpYk
+ umask 022
+ cd /home/testinstall/src/rpm/BUILD
+ cd KOceanSaver
+ '[' 1 -eq 1 ']'
+ rm -rf /home/testinstall/src/rpm/BUILDROOT/KOceanSaver-0.71-1slingshot2013.i386
+ make DESTDIR=/home/testinstall/src/rpm/BUILDROOT/KOceanSaver-0.71-1slingshot2013.i386 install
make: *** No rule to make target `install'.  Stop.
error: Bad exit status from /home/testinstall/src/tmp/rpm-tmp.sKQpYk (%install)


RPM build errors:
    Bad exit status from /home/testinstall/src/tmp/rpm-tmp.sKQpYk (%install)


[TerryN]

Executing(%build): /bin/sh -e /home/testinstall/src/tmp/rpm-tmp.QP1FSC
+ umask 022
+ cd /home/testinstall/src/rpm/BUILD
+ cd KOceanSaver
...
+ mkdir -p build
+ cd build
+ /usr/bin/cmake .. -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_INSTALL_LIBDIR:PATH=/usr/lib -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DCMAKE_BUILD_TYPE=release -DCMAKE_SKIP_RPATH:BOOL=ON -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_STATIC_LIBS:BOOL=OFF '-DCMAKE_MODULE_LINKER_FLAGS=-Wl,--as-needed  -Wl,-z,relro'
...
-- Build files have been written to: /home/testinstall/src/rpm/BUILD/KOceanSaver/build
...
Executing(%install): /bin/sh -e /home/testinstall/src/tmp/rpm-tmp.sKQpYk
+ umask 022
+ cd /home/testinstall/src/rpm/BUILD
+ cd KOceanSaver
+ '[' 1 -eq 1 ']'
+ rm -rf /home/testinstall/src/rpm/BUILDROOT/KOceanSaver-0.71-1slingshot2013.i386
+ make DESTDIR=/home/testinstall/src/rpm/BUILDROOT/KOceanSaver-0.71-1slingshot2013.i386 install
make: *** No rule to make target `install'.  Stop.
error: Bad exit status from /home/testinstall/src/tmp/rpm-tmp.sKQpYk (%install)
m /home/testinstall/src/tmp/rpm-tmp.sKQpYk (%install)

You can see that the config/build files have been written to a subdirectory called build.
Therefore your install should be:

Code: [Select]

%{makeinstall_std} -C build
Terry.

[sling-shot]

That worked as you suggested. Another point learnt.
--------------
Now the package builds on both 32 and 64 architectures. It seems to install / uninstall fine on both.
I have noticed that while the SRPM is 13 MB the RPM is only 4+ MB. Is something missing from the RPM?
It does not seem to work as expected on my machine at least.
I can see an entry in System Settings > Display and Monitor > Screen Locker > Screensaver.
On clicking Test, I get a translucent black film? which occupies the whole desktop. Nothing else. I do not see any fish/ocean/waves as promised in the screenshots.

I have AMD APU E450 with fglrx driver installed. Desktop effects are enabled and working.
Compositing type : OpenGL
Qt graphics : Raster

[sling-shot]

RPM - http://dl.dropbox.com/u/37931428/KOceanSaver/KOceanSaver-0.71-1slingshot2013.i586.rpm
SRPM - http://dl.dropbox.com/u/37931428/KOceanSaver/KOceanSaver-0.71-1slingshot2013.src.rpm
SPEC - http://dl.dropbox.com/u/37931428/KOceanSaver/slingshot-koceansaver-01.spec
LOG - http://dl.dropbox.com/u/37931428/KOceanSaver/slingshot-koceansaver-01.spec.log

-----

[7272andy]

Just gave it a quick test and I'm getting the same results as you.

I haven't got started packaging yet so am not really qualified to comment but I did notice a couple of not found lines in the spec log, could they have some bearing on things?

[pinoc]

we already had a koceansaver-0.5 src.rpm, so I updated this to 0.71 and sent it to the upload queue for 32/64.
-p.

[sling-shot]

we already had a koceansaver-0.5 src.rpm, so I updated this to 0.71 and sent it to the upload queue for 32/64.
-p.

Synaptic search did not show koceansaver. So it did not occur to look for an src.rpm in the repo.
------
I presume it is working properly on your end then?
------
Is there anything wrong with the .spec I have used above? (I am asking this because I hope to learn as much as possible from my efforts)

[sling-shot]

Just gave it a quick test and I'm getting the same results as you.

I haven't got started packaging yet so am not really qualified to comment but I did notice a couple of not found lines in the spec log, could they have some bearing on things?

Do you mean these

Code: [Select]

-- Looking for Q_WS_WIN
-- Looking for Q_WS_WIN - not found
-- Looking for Q_WS_QWS
-- Looking for Q_WS_QWS - not found
-- Looking for Q_WS_MAC
-- Looking for Q_WS_MAC - not found

They deal with other OS I believe hence not to worry.

[pinoc]

the older 64bit srpm is here, updated to new 0.71 source and that was it, working fine.
regards,
-p.

[sling-shot]

I looked into that .spec.
My untrained eye sees only 2 things:
1. BuildRequires: python-qt4-opengl. Although I have not specified it in the .spec file, it is already installed on the build system possibly for a previous effort.
2.

Code: [Select]

%build
cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr CMakeLists.txt
%{__make} %{?_smp_mflags} %{?mflags}

%install
%{__make} %{?mflags_install} DESTDIR=$RPM_BUILD_ROOT install

I do not understand what this does differently from the lines used in my .spec.

May no. 2  above be the cause of failure of my build to work properly?