Author Topic: gweled test package  (Read 376 times)

Offline rick0612

  • Sr. Member
  • ****
  • Posts: 258
  • The only dumb question is the one not asked.
gweled test package
« on: January 13, 2013, 01:10:00 PM »
Finished building gweled for 32-bit and 64-bit.
Changed specs file so both 32-bit and 64-bit can build with only one spec. In order to do that, I had to change the libraries to the matching numbers in both architechures. See the following:

changed librsvg-devel to %{_lib}rsvg2-devel
changed libgnomeui-devel to %{_lib}gnomeui2_0-devel
changed libglade2.0-devel to %{_lib}glade2.0_0-devel

The builds went well and the game installed and played with no problem in both 32-bit and 64-bit.

My first question is; are the library changes OK?

The next question is about submitting. I know I have to submit for testing and critiquing but how do I do that? I have a dropbox account if that helps.

Rick.

EDIT: Hey folks how about some feed back.

When I changed the libraries from the originals to version 2 so we can use one spec file for 32-bit and 64-bit builds, was that a good or bad thing?
When I found the patch was not relevant to PCLOS and removed it, was that a good or bad thing? (I can do the research again and supply links if needed.)
Did I really destroy previous developers' work or improve it?
Is my change log sufficient?

You are begging for packagers; please help new ones with feed back.
« Last Edit: January 16, 2013, 08:51:21 AM by rick0612 »
Packaging rig: Averatec 2573 /12.1" screen /2.0GHZ /3GB RAM /120GB SSD /Minime 2012.12

Daily rig: Alienware X51 /23" monitor /Windows 7 host /KDE VBox client

Online daniel

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3737
  • God knows, i'm not an Angel!
    • Tipps und Tricks
Re: gweled test package
« Reply #1 on: January 13, 2013, 01:24:11 PM »
Is it working, and installing without any problems on both arch, then you have made a good job.
Congratulations  :)

Send a pm to Neal, he will send you a account mail for dropbox.

Online ghostbunny

  • PCLinuxOS Tester
  • Hero Member
  • *******
  • Posts: 1162
Re: gweled test package
« Reply #2 on: January 13, 2013, 03:00:16 PM »
could you first post links to your srpm and the binary rpms for testing
The full life is a big mess

PS:
I'm German. Sorry because of possible mistakes in my written messages xD


Offline rick0612

  • Sr. Member
  • ****
  • Posts: 258
  • The only dumb question is the one not asked.
Packaging rig: Averatec 2573 /12.1" screen /2.0GHZ /3GB RAM /120GB SSD /Minime 2012.12

Daily rig: Alienware X51 /23" monitor /Windows 7 host /KDE VBox client

Offline gseaman

  • PCLinuxOS Tester
  • Hero Member
  • *******
  • Posts: 3793
Re: gweled test package
« Reply #4 on: January 13, 2013, 04:38:49 PM »
Why did you remove the German descriptions?

Galen

Offline gseaman

  • PCLinuxOS Tester
  • Hero Member
  • *******
  • Posts: 3793
Re: gweled test package
« Reply #5 on: January 13, 2013, 05:04:10 PM »
I built and installed without any problems.  :D

Galen

Online ghostbunny

  • PCLinuxOS Tester
  • Hero Member
  • *******
  • Posts: 1162
Re: gweled test package
« Reply #6 on: January 13, 2013, 05:07:09 PM »
Why did you remove the German descriptions?

Galen

+1

in general what was the reason for this rebuild and to remove the patch which is especially for version 0.9.1. I#m not a c/cpp programmer so i can't say what the patch fixes exactly but i don't believe that it would be there when it isn't necessary.

sorry but currently i just see the efforts of other packagers destroyed.
The full life is a big mess

PS:
I'm German. Sorry because of possible mistakes in my written messages xD


Offline rick0612

  • Sr. Member
  • ****
  • Posts: 258
  • The only dumb question is the one not asked.
Re: gweled test package
« Reply #7 on: January 14, 2013, 07:09:51 AM »
ghostbunny,

This is a practice rebuild for a new packager. I am looking for constructive criticism.
I researched the patch and found it was built specifically for an Ubuntu permissions issue that they say is irrelevant (I believe it was in bugzilla?). I can't see adding lines that don't add to the value of the program.

Galen,

I can put the German descriptions back. Would that be in respect for the developer?

Rick.
Packaging rig: Averatec 2573 /12.1" screen /2.0GHZ /3GB RAM /120GB SSD /Minime 2012.12

Daily rig: Alienware X51 /23" monitor /Windows 7 host /KDE VBox client

Online daniel

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3737
  • God knows, i'm not an Angel!
    • Tipps und Tricks
Re: gweled test package
« Reply #8 on: January 14, 2013, 09:18:13 AM »
And what is the reason to remove the german description?