gweled patch

[rick0612]

There is a patch connected to the gweled srpm that has me puzzled. (No pun intended)

The name of the patch is gweled-0.9.1-fix-open.patch
The site http://gweled.org  doesn't show the patch.
This site doesn't show the patch either  https://launchpad.net/gweled
I traced the creator of the patch to Peter Fox and it was built for Bug#395559.
https://launchpad.net/gweled bug reports link this bug to Bug#385564 and says it is invalid.
It appears to be setting permissions, do we need this? If all it is is permissions, I'll try packaging the srpm without the patch and see how it works.
EDIT: Just remembered that the patch is not mentioned in the changelog. Don't know who added it or when.
Here is the patch in its entirety:

--- gweled-0.9.1/src/games-setgid-io.c.open   2011-04-04 12:04:00.000000000 +0200
+++ gweled-0.9.1/src/games-setgid-io.c   2011-04-04 12:19:15.000000000 +0200
@@ -212,7 +212,7 @@ setgid_io_open_priv (int outfd, int infd
   read_n_bytes (infd, path, length);
   flags = read_int (infd);
 
-  newfd = open (path, flags);
+  newfd = open (path, flags,S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH);
 
   write_int (outfd, newfd);
   g_free (path);

Rick.

[ghostbunny]

i can't say about the importance of this patch because i'm not a c programer but i wouldn't remove it. why should it be added when it doesn't solve problems?

EDIT: Just remembered that the patch is not mentioned in the changelog. Don't know who added it or when.

the patch has in the file name the version for which it was created. so probably the guy which packaged 0.9.1 has added it. but a changelog entry for this version is missing and the package cache for the packager is also empty. so we will never know it.

[MBantz]

My guess is that it relates to new files created by gweled - I woulden't remove it either unless there is a fully understanding of what it does and why.

The changelog is primarily info between pclinuxos packagers, if the package is fetched from other distros the changelog is normally reset,

cheers,
MBantz

[ghostbunny]

The changelog is primarily info between pclinuxos packagers, if the package is fetched from other distros the changelog is normally reset,

cheers,
MBantz

the package is in the pclos repo since 2007 and got some updates all with a changelog entry of the packager except the last one which is missing. there was no reset.